Skip to content

Add periodictable MCP tool config - #1422

Merged
cmunley1 merged 4 commits into
mainfrom
feat/periodictable-mcp-tool
Jun 16, 2026
Merged

cmunley1 merged 4 commits into
mainfrom
feat/periodictable-mcp-tool

Conversation

@tamohannes

Copy link
Copy Markdown
Contributor

Summary

  • Add a NeMo-Gym ns_tools config that exposes PeriodictableTool through the existing NeMo-Skills ToolManager bridge.
  • Add a focused config test to keep the resource-server wiring valid.
  • This is the Gym-side companion to Add periodictable MCP tool Skills#1421.

Replaces fork-origin PR #1219 so CI can run with full repository secrets.

Test plan

  • PYTHONPATH=. python -m pytest resources_servers/ns_tools/tests/test_periodictable_mcp_config.py -q --tb=short

Signed-off-by: tamohannes <hovhannes.tamoyan@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented May 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: tamohannes <hovhannes.tamoyan@gmail.com>
@tamohannes
tamohannes requested a review from gwarmstrong May 27, 2026 00:13
@cmunley1
cmunley1 merged commit 723f4d4 into main Jun 16, 2026
9 checks passed
@cmunley1
cmunley1 deleted the feat/periodictable-mcp-tool branch June 16, 2026 17:25
ritaneves pushed a commit that referenced this pull request Jun 25, 2026
## Summary

- Add a NeMo-Gym `ns_tools` config that exposes `PeriodictableTool`
through the existing NeMo-Skills ToolManager bridge.
- Add a focused config test to keep the resource-server wiring valid.
- This is the Gym-side companion to NVIDIA-NeMo/Skills#1421.

Replaces fork-origin PR #1219 so CI can run with full repository
secrets.

## Test plan

- `PYTHONPATH=. python -m pytest
resources_servers/ns_tools/tests/test_periodictable_mcp_config.py -q
--tb=short`

---------

Signed-off-by: tamohannes <hovhannes.tamoyan@gmail.com>
Co-authored-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Rita Fernandes Neves <rfernandesne@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants